Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect dark mode system preference for background color #1208

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

jotaen4tinypilot
Copy link
Contributor

@jotaen4tinypilot jotaen4tinypilot commented Nov 22, 2022

Resolves #1091, by automatically making the site’s background-color dark, if the user prefers a dark color scheme.

Screen.Recording.2022-11-22.at.17.16.57.mov

The dark background color is technically a very dark brown. I think it makes sense to not make it pitch black (like #000), so that the borders of the remote screen are still discernible even if it happens to render all black. (E.g., the “no signal” placeholder.)

Two notes:

  • For the onscreen keyboard, it’s currently tricky to make it dark, because its color values are mostly hard-coded. We’d have to refactor that first, but I’m not sure how worthwhile that is. For now, I think it’s bearable.
  • The dialogs must stay bright, because otherwise they wouldn’t have enough contrast against the dark overlay background.

Review on CodeApprove

Copy link
Contributor

@mtlynch mtlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved

Nice!

LGTM, thanks


👀 @jotaen4tinypilot it's your turn please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect dark mode system preference
2 participants